Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Windows ARM64 releases on windows-latest instead #2275

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Run Windows ARM64 releases on windows-latest instead #2275

merged 2 commits into from
Jul 11, 2024

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Jul 9, 2024

@nex3 nex3 requested a review from jathak July 9, 2024 22:48
@ntkme
Copy link
Contributor

ntkme commented Jul 9, 2024

The problem seems to be that in composite action an explicit shell is required, but in a normal action the shell defaults to bash on linux and mac and pwsh windows. However, there is no way to get the same conditional behavior on the in a composite action.

For building the release, we can get it working without using the composite action. I've put up a PR for it.

@nex3 Would you mind try if #2274 works?

@nex3
Copy link
Contributor Author

nex3 commented Jul 9, 2024

Closing in favor of #2274

@nex3 nex3 closed this Jul 9, 2024
@nex3 nex3 mentioned this pull request Jul 11, 2024
@nex3 nex3 reopened this Jul 11, 2024
@nex3 nex3 changed the title Disable windows-arm64 releases for now un Windows ARM64 releases on windows-latest instead Jul 11, 2024
@nex3 nex3 changed the title un Windows ARM64 releases on windows-latest instead Run Windows ARM64 releases on windows-latest instead Jul 11, 2024
@nex3 nex3 requested a review from jathak July 11, 2024 00:59
@nex3 nex3 merged commit be9c3ac into main Jul 11, 2024
68 checks passed
@nex3 nex3 deleted the fix-deploy branch July 11, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants